go/aicra
go
/
aicra
0
1
Fork 0
Code Issues Pull Requests Releases 3 Wiki Activity

test dynfunc package; standardize and refactor api #14

Merged
xdrm-brackets merged 19 commits from test/dynamic into 0.3.0 2020-04-04 10:09:20 +00:00
Conversation 0 Commits 19 Files Changed 20 +6 -6
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit db4429b329 - Show all commits

12
dynamic/spec.go
View File

@ -17,6 +17,9 @@ func makeSpec(service config.Service) spec {
} }
for _, param := range service.Input { for _, param := range service.Input {
if len(param.Rename) < 1 {
continue
}
// make a pointer if optional // make a pointer if optional
if param.Optional { if param.Optional {
spec.Input[param.Rename] = reflect.PtrTo(param.ExtractType) spec.Input[param.Rename] = reflect.PtrTo(param.ExtractType)
@ -26,6 +29,9 @@ func makeSpec(service config.Service) spec {
} }
for _, param := range service.Output { for _, param := range service.Output {
if len(param.Rename) < 1 {
continue
}
spec.Output[param.Rename] = param.ExtractType spec.Output[param.Rename] = param.ExtractType
} }
@ -53,9 +59,6 @@ func (s spec) checkInput(fnv reflect.Value) error {
// check for invalid param // check for invalid param
for name, ptype := range s.Input { for name, ptype := range s.Input {
if len(name) < 1 {
continue
}
if name[0] == strings.ToLower(name)[0] { if name[0] == strings.ToLower(name)[0] {
return fmt.Errorf("%s: %w", name, ErrUnexportedName) return fmt.Errorf("%s: %w", name, ErrUnexportedName)
} }
@ -108,9 +111,6 @@ func (s spec) checkOutput(fnv reflect.Value) error {
// fail on invalid output // fail on invalid output
for name, ptype := range s.Output { for name, ptype := range s.Output {
if len(name) < 1 {
continue
}
if name[0] == strings.ToLower(name)[0] { if name[0] == strings.ToLower(name)[0] {
return fmt.Errorf("%s: %w", name, ErrUnexportedName) return fmt.Errorf("%s: %w", name, ErrUnexportedName)
} }