fix: ineffectual assignments

This commit is contained in:
Adrien Marquès 2021-06-22 21:14:38 +02:00
parent ad86a3b46b
commit c048db76e6
Signed by: xdrm-brackets
GPG Key ID: D75243CA236D825E
1 changed files with 4 additions and 6 deletions

View File

@ -51,13 +51,11 @@ func TestWith(t *testing.T) {
middleware := func(next http.Handler) http.Handler { middleware := func(next http.Handler) http.Handler {
return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
newr := r
// first time -> store 1 // first time -> store 1
value := r.Context().Value(key) value := r.Context().Value(key)
if value == nil { if value == nil {
newr = r.WithContext(context.WithValue(r.Context(), key, int(1))) r = r.WithContext(context.WithValue(r.Context(), key, int(1)))
next.ServeHTTP(w, newr) next.ServeHTTP(w, r)
return return
} }
@ -67,8 +65,8 @@ func TestWith(t *testing.T) {
t.Fatalf("value is not an int") t.Fatalf("value is not an int")
} }
cast++ cast++
newr = r.WithContext(context.WithValue(r.Context(), key, cast)) r = r.WithContext(context.WithValue(r.Context(), key, cast))
next.ServeHTTP(w, newr) next.ServeHTTP(w, r)
}) })
} }